Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
ef66945
Add automatic message encoding/decoding via codec registry
baelter Mar 9, 2026
2e8dbd7
Add e2e integration tests for codec registry
baelter Mar 9, 2026
ff6eeb0
Address PR review feedback
baelter Mar 9, 2026
b6b6485
Improve error messages and feature detection
baelter Mar 9, 2026
d442966
Bump minimum Node version to 18
baelter Mar 9, 2026
06616f1
Fail fast on misconfigured publish
baelter Mar 9, 2026
a50d7ef
Wire codec registry into RPC client and server
baelter Mar 10, 2026
38953ee
Fix TS4111: use AMQPProperties type instead of Record for replyProps
baelter Mar 10, 2026
0264b60
Add type-safe publish overloads and fix unsafe as casts (#193)
baelter Mar 13, 2026
249915f
Fix undefined body guard, decode asymmetry, RPC type holes
baelter Mar 13, 2026
5e79d10
Redesign codec typing with inferred generic and SessionMessage
baelter Mar 13, 2026
ba66e7d
Replace boolean generic with CodecMode string literal union
baelter Mar 13, 2026
238cb6b
Replace SessionMessage wrapper with AMQPMessage<CodecMode> generic
baelter Mar 13, 2026
a6f04e4
Extract isBody() type guard from inline checks
baelter Mar 13, 2026
cb45020
Move CodecMode to amqp-message, reduce public API surface
baelter Mar 13, 2026
e623a05
Skip decodeMessage in plain mode, trust the type system
baelter Mar 13, 2026
c5b1115
Type publish pipeline with PublishBody<C> instead of unknown
baelter Mar 13, 2026
e3f80d7
Replace unknown with PublishBody<C> | Serializable in overload impls
baelter Mar 13, 2026
acad8a6
Remove generic from consume-side classes
baelter Mar 16, 2026
21c118d
Fix prettier formatting
baelter Mar 16, 2026
b06d0fe
Fix type errors in low-level tests after msg.body became unknown
baelter Mar 16, 2026
fe80e98
Keep body as Uint8Array field, add decodedBody for codec output
baelter Mar 16, 2026
aae8780
Simplify implementation overload body type to Serializable
baelter Mar 16, 2026
86e418a
Remove Serializable overloads from publish methods
baelter Mar 16, 2026
207b9f4
Rename Serializable to Body, old Body to WireBody
baelter Mar 16, 2026
622c50d
Rename WireBody to PlainBody
baelter Mar 16, 2026
cbe578c
Rename PublishBody to Body, make Serializable internal
baelter Mar 16, 2026
de5e911
Simplify subscribe callback wrapping in AMQPQueue
baelter Mar 16, 2026
75cacea
Replace callback chaining with single wrapper in subscribe
baelter Mar 16, 2026
c6ec8ac
Extract wrapCallback utility from subscribe
baelter Mar 16, 2026
5e9365f
Rename wrapCallback to wrapCallbackWithAutoDecodeAndAck
baelter Mar 16, 2026
8af06fd
Move undefined check into wrapCallbackWithAutoDecodeAndAck
baelter Mar 16, 2026
d4e4eb6
Reassign callback instead of creating wrappedCallback
baelter Mar 16, 2026
cfe9182
Move decodeMessage into AMQPCodecRegistry, delete amqp-session-messag…
baelter Mar 16, 2026
9ef71e0
Make msg.body the single decoded field, drop _ prefix convention
baelter Mar 16, 2026
9531dbe
Restore property documentation on AMQPMessage as inline JSDoc
baelter Mar 16, 2026
2354772
Add inline JSDoc to all public class fields
baelter Mar 16, 2026
bb261b6
Revert eslint config to recommended, remove unneeded disable comments
baelter Mar 16, 2026
7fc6a86
Restore direct reply-to comment in AMQPRPCClient
baelter Mar 16, 2026
e422e3f
Move CodecMode from amqp-message to amqp-publisher
baelter Mar 16, 2026
2e347ef
Add compile-time type safety tests for CodecMode generics
baelter Mar 17, 2026
e035394
Address review feedback: type-safe RPCHandler, decode-in-try, sync fa…
baelter Mar 17, 2026
ef78ea3
Use instanceof AMQPError to distinguish channel-close from decode errors
baelter Mar 17, 2026
f18839f
Fix formatting, add CLAUDE.md with pre-commit checks
baelter Mar 17, 2026
6950ba5
Make AMQPMessage generic on CodecMode
baelter Mar 17, 2026
bbd9944
Use requeueOnNack for decode errors in generator subscriptions
baelter Mar 17, 2026
4475334
Codec registry refactor (#198)
antondalgren May 6, 2026
e17645f
Replace codec factory functions with builtin registry constants
baelter May 7, 2026
0a2ae91
Accept AMQPExchange handle in AMQPQueue bind/unbind
baelter May 7, 2026
492c6c0
Default deliveryMode to 2 (persistent) in publish
baelter May 7, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .review-config
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
REVIEWER=copilot
CRITERIA=.github/copilot-instructions.md
MODEL=gpt-4.1
38 changes: 38 additions & 0 deletions CLAUDE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# amqp-client.js

AMQP 0-9-1 client library for Node.js and browsers.

## Before committing

Run these checks and fix any issues:

```sh
npm run format:check # prettier
npm run lint # eslint
npm run typecheck # tsc --noEmit
```

To auto-fix formatting: `npm run format`

## Testing

```sh
npx vitest run test/<file>.ts # run specific test file
npm run test:local # run local tests with coverage
```

Full `npm test` (with coverage for all tests) may OOM — prefer targeted runs.

## Project structure

- `src/` — TypeScript source (ESM)
- `test/` — vitest tests
- `lib/` — build output (gitignored)
- `types/` — generated declarations (gitignored)

## Key conventions

- Prettier for formatting, eslint for linting
- `CodecMode` generic (`"plain" | "codec"`) threads through session/queue/exchange/rpc classes
- `AMQPMessage.body` starts as raw bytes, gets replaced by decoded value when codecs are configured
- `@internal` JSDoc + `stripInternal: true` hides internal API from declarations
7 changes: 7 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ export default tseslint.config(
eslint.configs.recommended,
tseslint.configs.recommended,
prettierConfig,
{
files: ["src/**/*.ts", "test/**/*.ts", "test-browser/**/*.ts"],
rules: {
// {} is used extensively as a default for ParserMap/CoderMap generics
"@typescript-eslint/no-empty-object-type": ["error", { allowObjectTypes: "always" }],
},
},
{
files: ["examples/*.js", "scripts/*.js"],
languageOptions: {
Expand Down
15 changes: 14 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"sideEffects": false,
"engines": {
"node": ">=16.0.0"
"node": ">=18.0.0"
},
Comment thread
baelter marked this conversation as resolved.
"scripts": {
"docs": "typedoc src/index.ts",
Expand Down
7 changes: 3 additions & 4 deletions src/amqp-base-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ export abstract class AMQPBaseClient {
const err = new AMQPError(msg, this)
channel.setClosed(err)
delete this.channels[channelId]

const closeOk = new AMQPFrame.Writer({
bufferSize: 12,
type: AMQPFrame.Type.METHOD,
Expand Down Expand Up @@ -669,7 +668,7 @@ export abstract class AMQPBaseClient {
if (message) {
message.bodySize = bodySize
message.properties = properties
message.body = new Uint8Array(bodySize)
message._rawBytes = new Uint8Array(bodySize)
if (bodySize === 0) channel.onMessageReady(message)
} else {
this.logger?.warn("Header frame but no message")
Expand All @@ -678,9 +677,9 @@ export abstract class AMQPBaseClient {
}
case AMQPFrame.Type.BODY: {
const message = channel.delivery || channel.getMessage || channel.returned
if (message && message.body) {
if (message && message._rawBytes) {
const bodyPart = new Uint8Array(view.buffer, view.byteOffset + i, frameSize)
message.body.set(bodyPart, message.bodyPos)
message._rawBytes.set(bodyPart, message.bodyPos)
message.bodyPos += frameSize
i += frameSize
if (message.bodyPos === message.bodySize) channel.onMessageReady(message)
Expand Down
1 change: 1 addition & 0 deletions src/amqp-channel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,7 @@ export class AMQPChannel {
* @param message
*/
onMessageReady(message: AMQPMessage): void {
message.body = message._rawBytes
if (this.delivery) {
delete this.delivery
this.deliver(message)
Expand Down
Loading
Loading