fixup! fix: propagate channel errors to connection and handle channel close properly

carlhoerberg · baelter · commit 749ca4b642c7 · 2025-09-09T13:20:14.000+02:00
diff --git a/src/amqp-channel.ts b/src/amqp-channel.ts
@@ -31,9 +31,7 @@ export class AMQPChannel {
     this.onerror = (reason: string) => {
       this.logger?.error(`channel ${this.id} closed: ${reason}`)
       // Propagate channel errors to the connection's onerror handler
-      if (this.id !== 0) { // Don't propagate for connection channel (id=0)
-        this.connection.onerror(new AMQPError(`Channel ${this.id} closed: ${reason}`, this.connection))
-      }
+      this.connection.onerror(new AMQPError(`Channel ${this.id} closed: ${reason}`, this.connection))
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,7 @@ export class AMQPChannel {`
`31`	`31`	`this.onerror = (reason: string) => {`
`32`	`32`	this.logger?.error(`channel ${this.id} closed: ${reason}`)
`33`	`33`	`// Propagate channel errors to the connection's onerror handler`
`34`		`- if (this.id !== 0) { // Don't propagate for connection channel (id=0)`
`35`		- this.connection.onerror(new AMQPError(`Channel ${this.id} closed: ${reason}`, this.connection))
`36`		`- }`
	`34`	+ this.connection.onerror(new AMQPError(`Channel ${this.id} closed: ${reason}`, this.connection))
`37`	`35`	`}`
`38`	`36`	`}`
`39`	`37`