Make context errors bite

squaremo · squaremo · commit 347c73b4722c · 2014-03-19T22:33:03.000Z
Something, I suspect promise machinery, was preventing unhandled
'error' events from killing the program. For that reason, the error
handler now uses setImmediate to emit the error.

Errors thrown in the ready handler were being stifled, as well, so
I've rearranged it slightly so they will trigger an error event.
diff --git a/lib/sockets.js b/lib/sockets.js
@@ -24,15 +24,17 @@ function bufferify(chunk, encoding) {
 
 function Context(url) {
   EventEmitter.call(this);
-  var onError = this.emit.bind(this, 'error');
+  var self = this;
+  var onError = function(e) {
+    setImmediate(self.emit.bind(self, 'error', e));
+  }
   var onClose = this.emit.bind(this, 'close');
   var c = this._connection = amqp.connect(url);
   c.then(function(conn) {
     conn.on('error', onError);
     conn.on('close', onClose);
   });
-  c.then(this.emit.bind(this, 'ready'),
-         onError);
+  c.then(this.emit.bind(this, 'ready')).then(null, onError);
 };
 inherits(Context, EventEmitter);
 
@@ -58,7 +60,7 @@ Context.prototype.socket = function(type, options) {
     }), options);
     return s;
   }
-  else throw('Undefined socket type ' + type);
+  else throw new Error('Undefined socket type ' + type);
 };
 
 Context.prototype.close = function(callback) {
