Normalize private fields to use TypeScript private keyword

baelter · baelter · commit 2da3fae68011 · 2026-03-06T13:24:06.000+01:00
Replace ES # private field (#acked) and underscore-prefixed fields
(_closed, _cancelPromise, _generator) with plain TypeScript private
for consistency across the codebase.
diff --git a/src/amqp-consumer.ts b/src/amqp-consumer.ts
@@ -51,13 +51,13 @@ export class AMQPConsumer {
    */
   cancel() {
     if (this.channel.closed) return Promise.resolve(this.channel)
-    if (!this._cancelPromise) {
-      this._cancelPromise = this.channel.basicCancel(this.tag)
+    if (!this.cancelPromise) {
+      this.cancelPromise = this.channel.basicCancel(this.tag)
     }
-    return this._cancelPromise
+    return this.cancelPromise
   }
 
-  private _cancelPromise?: Promise<AMQPChannel>
+  private cancelPromise?: Promise<AMQPChannel>
 
   /**
    * @ignore
@@ -78,7 +78,7 @@ export class AMQPConsumer {
 export class AMQPGeneratorConsumer extends AMQPConsumer {
   private messageQueue: AMQPMessage[] = []
   private messageResolver: ((msg: AMQPMessage) => void) | null = null
-  private _generator?: AsyncGenerator<AMQPMessage, void, undefined>
+  private generator?: AsyncGenerator<AMQPMessage, void, undefined>
 
   constructor(channel: AMQPChannel, tag: string) {
     super(channel, tag, (msg: AMQPMessage) => {
@@ -97,12 +97,12 @@ export class AMQPGeneratorConsumer extends AMQPConsumer {
    * @return An AsyncGenerator that yields messages
    */
   get messages(): AsyncGenerator<AMQPMessage, void, undefined> {
-    if (this._generator) {
-      return this._generator
+    if (this.generator) {
+      return this.generator
     }
 
-    this._generator = this.generateMessages()
-    return this._generator
+    this.generator = this.generateMessages()
+    return this.generator
   }
 
   private async *generateMessages(): AsyncGenerator<AMQPMessage, void, undefined> {
diff --git a/src/amqp-message.ts b/src/amqp-message.ts
@@ -30,11 +30,11 @@ export class AMQPMessage {
   messageCount?: number
   replyCode?: number
   replyText?: string
-  #acked = false
+  private acked = false
 
   /** True if the message has already been acked, nacked, or rejected. */
   get isAcked(): boolean {
-    return this.#acked
+    return this.acked
   }
 
   /**
@@ -62,22 +62,22 @@ export class AMQPMessage {
 
   /** Acknowledge the message */
   ack(multiple = false) {
-    if (this.#acked) return Promise.resolve()
-    this.#acked = true
+    if (this.acked) return Promise.resolve()
+    this.acked = true
     return this.channel.basicAck(this.deliveryTag, multiple)
   }
 
   /** Negative acknowledgment (same as reject) */
   nack(requeue = false, multiple = false) {
-    if (this.#acked) return Promise.resolve()
-    this.#acked = true
+    if (this.acked) return Promise.resolve()
+    this.acked = true
     return this.channel.basicNack(this.deliveryTag, requeue, multiple)
   }
 
   /** Reject the message */
   reject(requeue = false) {
-    if (this.#acked) return Promise.resolve()
-    this.#acked = true
+    if (this.acked) return Promise.resolve()
+    this.acked = true
     return this.channel.basicReject(this.deliveryTag, requeue)
   }
 
