chore: Make npm scripts cross-platform compatible#179
Merged
Conversation
Member
Author
|
Fixes #164 |
baelter
approved these changes
Nov 28, 2025
Replace Unix-specific shell commands with Node.js scripts to ensure compatibility across Windows, macOS, and Linux: - Replace `rm -rf` with fs.rmSync() in prebuild script - Replace `echo` redirect with fs.writeFileSync() in postbuild script - Replace macOS-specific `sed` command with Node.js file operations in version script All scripts use Node.js built-in APIs (fs, path) with no additional dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
7afd705 to
70d8e3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/clean.jsto replacerm -rfwithfs.rmSync()scripts/write-cjs-package.jsto replaceechoredirect withfs.writeFileSync()scripts/update-version.jsto replace macOS-specificsedcommand with Node.js file operationsChanges
prebuild script:
rm -rf dist lib typesnode scripts/clean.jspostbuild script:
echo '{"type": "commonjs"}' > lib/cjs/package.jsonnode scripts/write-cjs-package.jsversion script:
sed -i '' "s/VERSION = .*/VERSION = \"$npm_package_version\"/" src/amqp-base-client.ts && ...node scripts/update-version.js && ...Benefits
fs.rmSync()is guaranteed to be availableTest plan
npm run prebuildsuccessfully removes dist/lib/types directoriesnpm run buildcompletes successfullylib/cjs/package.jsonis created correctly with{"type": "commonjs"}🤖 Generated with Claude Code