Add AsyncGenerator support to subscribe() for improved DX#169
Merged
antondalgren merged 1 commit intomainfrom Nov 12, 2025
Merged
Add AsyncGenerator support to subscribe() for improved DX#169antondalgren merged 1 commit intomainfrom
antondalgren merged 1 commit intomainfrom
Conversation
antondalgren
requested review from
ThomasSarlin,
baelter,
carlhoerberg and
dentarg
as code owners
antondalgren
force-pushed
the
add-async-generator-subscribe
branch
from
614ceb1 to
bd6924b
Compare
Extends queue.subscribe() to support AsyncGenerator-based message consumption via consumer.messages property when no callback is provided. Benefits: - Natural iteration with for await...of loops - Automatic consumer cancellation on loop exit - Better backpressure control - Access to consumer methods (wait, cancel, tag) Implementation: - New AMQPGeneratorConsumer subclass handles generator logic - subscribe() overloads: with callback returns AMQPConsumer, without callback returns AMQPGeneratorConsumer - consumer.messages property (not method) for cleaner syntax - Reuses existing callback infrastructure for message delivery Fixes #168 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
antondalgren
force-pushed
the
add-async-generator-subscribe
branch
from
bd6924b to
6aece30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends queue.subscribe() to support AsyncGenerator-based message consumption via consumer.messages property when no callback is provided.
Benefits:
Implementation:
Fixes #168
🤖 Generated with Claude Code