fix: remove unecessary as casting#140
Merged
antondalgren merged 1 commit intomainfrom May 27, 2025
Merged
Conversation
antondalgren
requested review from
ThomasSarlin,
baelter,
carlhoerberg and
dentarg
as code owners
baelter
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving type safety and code clarity by refining TypeScript type annotations and removing unnecessary type assertions. The changes primarily affect methods in the
AMQPChannel,AMQPQueue, andAMQPViewclasses.TypeScript type safety improvements:
src/amqp-channel.ts: Updated thequeue,queueDeclare, andexchangeDeclaremethods to use explicit type annotations for default parameter values, replacing type assertions with inline type definitions for cleaner and safer code. [1] [2] [3]src/amqp-queue.ts: Refined thesubscribemethod parameters by replacing the type assertion with an inline type definition, ensuring consistency with other method signatures.src/amqp-view.ts: Removed redundant type assertions in thesetLongStringandsetBigInt64method calls, relying on TypeScript's type inference for improved readability and maintainability.