chore: Add package-lock.json#139
Merged
antondalgren merged 1 commit intomainfrom May 27, 2025
Merged
Conversation
antondalgren
requested review from
ThomasSarlin,
baelter,
carlhoerberg and
dentarg
as code owners
ThomasSarlin
approved these changes
May 27, 2025
Contributor
ThomasSarlin
left a comment
ThomasSarlin
left a comment
There was a problem hiding this comment.
Lgtm, just add a more descriptive comment on why this change is made for future reference :)
Member
|
For libraries you normally dont have a checked in lock file, only for your apps. |
Member
|
It's the consumers of this library that should have their locks files checked in. No one will use this lock file. |
carlhoerberg
added a commit
that referenced
this pull request
May 27, 2025
This reverts commit c393d37.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is good practice to have a lockfile. Not having one could expose us to supply chain attacks.