Skip to content

Increase min frameMax to 8kB#134

Merged
dentarg merged 4 commits intomainfrom
frame-max-8kb
Apr 6, 2025
Merged

Increase min frameMax to 8kB#134
dentarg merged 4 commits intomainfrom
frame-max-8kb

Conversation

@carlhoerberg
Copy link
Copy Markdown
Member

For compability with RabbitMQ 4.1 and large JWT tokens: rabbitmq/rabbitmq-server#13541

@dentarg
Copy link
Copy Markdown
Member

dentarg commented Apr 5, 2025

Do we need to release this as v4.0.0 (breaking change)?

Comment thread CHANGELOG.md Outdated
@dentarg
Copy link
Copy Markdown
Member

dentarg commented Apr 6, 2025

Do we need to release this as v4.0.0 (breaking change)?

Maybe not breaking change, as it is only breaking for the users that explicitly use something lower than 8192.

@dentarg
Copy link
Copy Markdown
Member

dentarg commented Apr 6, 2025

I tested our current version (3.2.0) against RabbitMQ 4.1.0 rc1, it fails (as expected) with ERROR AMQPError: Connection ended and a bunch of stack traces, RabbitMQ logs

2025-04-06T07:12:44.579678+00:00 error: FORMATTER CRASH: {"closing AMQP connection ~tp (~ts):~nfailed to negotiate connection parameters: ~ts",[<0.3100.0>,<<"85.194.166.224:55750 -> 10.56.72.15:5671">>,"3s","negotiated frame_max = 4096 is lower than the minimum allowed value (8192)"]}

Using this PR (npm install --save-dev cloudamqp/amqp-client.js#pull/134/head), there's no problem.

@dentarg dentarg merged commit f874bc1 into main Apr 6, 2025
5 checks passed
@dentarg dentarg deleted the frame-max-8kb branch April 6, 2025 07:42
@dentarg
Copy link
Copy Markdown
Member

dentarg commented Apr 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants