fix: properly reject when socket ends during connection#122
Merged
carlhoerberg merged 2 commits intocloudamqp:mainfrom Mar 7, 2025
Merged
fix: properly reject when socket ends during connection#122carlhoerberg merged 2 commits intocloudamqp:mainfrom
carlhoerberg merged 2 commits intocloudamqp:mainfrom
Conversation
Contributor
Author
|
I looked at the websocket tests to see what's wrong there, as far as I can tell for some reason socket error event is not emitted for websocket client. But since #123 has the same issue and I didn't really touch anything that would break the test I don't think this should be a blocker. @carlhoerberg can you have a look at this PR, I've been hunting for this bug on and off for almost a year and would love to get it merged. |
Contributor
Author
|
@baelter Sorry to tag directly but I see you've committed to this repository in the past month. Can You please have a look at this PR, it's a serious issue. |
carlhoerberg
force-pushed
the
fix-connect-hang
branch
from
affc41d to
756ca3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #121
Might not be the prettiest solution, feel free to edit my fork if you feel the need to.